Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: fixing GL08 errors for pandas.IntervalIndex.right and pandas.Series.dt #57732

Closed
wants to merge 7 commits into from
Closed

DOC: fixing GL08 errors for pandas.IntervalIndex.right and pandas.Series.dt #57732

wants to merge 7 commits into from

Conversation

s1099
Copy link
Contributor

@s1099 s1099 commented Mar 5, 2024 •
edited
Loading

Resolved GL08 errors for the following:

  1. scripts/validate_docstrings.py --format=actions --errors=GL08 pandas.IntervalIndex.right
  2. scripts/validate_docstrings.py --format=actions --errors=GL08 pandas.Series.dt

xref: #57443

@s1099 s1099 requested a review from mroeschke as a code owner March 5, 2024 08:13
@s1099
Copy link
Contributor Author

s1099 commented Mar 5, 2024

pre-commit.ci autofix

datapythonista
datapythonista reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@datapythonista datapythonista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind splitting the two docstrings in separate pull requests please? I have some comments, but reviewing them together is not very efficient. Surely feel free to work in the same PR for the right and left methods, since they'll be pretty much the same, but for unrelated docstrings it will force us to review the two of them at each iteration, even when one of them is already finished.

@datapythonista
Copy link
Member

Also, since you worked on the main branch, you may want to clone pandas again and start the work in different branches. If you work in main, then any new branch you create to work in different things in parallel will contain the changes you made in main, and you will have unrelated things in the branches. In general you want to make sure you never commit to main and it's synced with the latest main in pandas, so when you create branches you start from the right state of pandas.

I'll close this PR, since you'll have to open new ones from the new branches, but surely happy to review your changes in those.

@s1099
Copy link
Contributor Author

s1099 commented Mar 6, 2024

moved to #57751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista datapythonista left review comments

@mroeschke mroeschke Awaiting requested review from mroeschke mroeschke is a code owner

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s1099 @datapythonista